Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try fixing widgets rendering #187

Merged
merged 3 commits into from
Jan 20, 2023
Merged

try fixing widgets rendering #187

merged 3 commits into from
Jan 20, 2023

Conversation

OriolAbril
Copy link
Member

Adds some extra javascript to ensure widgets are rendered correctly
as static elements even without access to a python kernel.

Also does some minor doc config updates, mainly making the light theme the default.

@OriolAbril
Copy link
Member Author

looks basically the same now 🤔

@aloctavodia
Copy link
Contributor

Yep, I am not able to spot any difference

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Merging #187 (6e86c31) into main (d91fcf9) will decrease coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   85.82%   85.56%   -0.27%     
==========================================
  Files          26       26              
  Lines        2554     2563       +9     
==========================================
+ Hits         2192     2193       +1     
- Misses        362      370       +8     
Impacted Files Coverage Δ
preliz/predictive/ppa.py 11.58% <0.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OriolAbril
Copy link
Member Author

Let's see how it looks now. It turns out ipywidgets adds one of these red broken chain icons per element that should be connected to a kernel but isn't. I guess it is informative, but a bit too much. I added an extra css rule to remove that.

@aloctavodia
Copy link
Contributor

Thanks, this looks much better!

@aloctavodia aloctavodia merged commit 6b94e6e into arviz-devs:main Jan 20, 2023
@OriolAbril OriolAbril deleted the docs branch January 20, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants